Build 307RC1-001

[Mike]

Updates and fixes: (also applies to 306 all builds)

The Enable Blocks option: (APC > PORTAL > Portal Config)

By default this option is checked, that is, all blocks are enabled (viewable).
Of course, while this option is checked, you can set block visibility on an individual basis.
If this option is disabled (unchecked) no block will be displayed, that is, it overrides all individual block options...

Previously, if this option was disabled (unchecked), we did not stop the actual processing of the the block code, we simply hid them from view... We now also disable the processing of the block code to allow faster fault finding... In effect, we have divided the portal code into tow part, a) block processing and b) normal core functions...

The main advantage from this action is the reduction in the amount of code we have to process (divide and concur)... we can now isolate the block generation code from the rest of the portal code, thereby making bugs finding easier...

Real world example:
I am currently chasing a bug where I can't log into the ACP using Firefox while the portal is disabled... mind you, I can with all other browsers...
This is a strange and possibly difficult to find bug... First appearances suggest it's down to firefox but could it be the portal code (at least in relation to firefox)?
At this point in time I simply don't know... but being able to disable all block code has made my job much easier... I can concentrate on the rest of the portal code... more on this later...

Turns out to be a firefox bug, basically add IF STARGATE switch to prevent portal code form loading while portal is once disabled... else we end up a second form being loaded... Fixed! 07 February 2010
A worthwhile exercise nevertheless...

Portal pages not found:
Report of pages not being found while phpBB redoes caching...
Fix = alter path to the files when user in admin... Fixed! 07 February 2010

Guest locked out of site and/or not able to use search engine:
The search block was too restrictive... If user wasn't registered we disable the site... Fixed! 08 February 2010

No message when no public forums exist:
Added portal message to indicate there are no public forums..
The default phpBB no forums message display fine... Fixed! 08 February 2010

Patch file available when I get a chance... in the mean time use these...

Replace file with attached file

block_search.zip

blocks/block_search.php

(1.2 KiB) Downloaded 21 times

[Mitch]

Replaced file now i get with admin account when doing a search
Sorry but you are not permitted to use the search system.

[Mike]

Did you purge cache?

[Mitch]

Yes Both places and verified by ftp

[Mike]

Open block_search.php and find

Code: Select all

   trigger_error($user->lang['NO_SEARCH']);

before it add // (comment it out)... and try again...
Should be no need to do this but it might tell us more....

One other thing...
I have noticed phpBB never adds administrator or global moderator right for forums... I have always assumed these did not require setting up for any forum but if you don't admin wont have access under certain conditions (this being one of them)...

As a test, before you add the edit above see if the administrator is added to any forum as a group, if not add them and set up rights... refresh page and see if there is any change... if not proceed with edit...

[Mitch]

Admin is added to all forums with full permissions.

Did the edit and the problem went away.

[Mike]

I think you need all the updates... should be in 307-001 soon.. want to test some more before committing...

[Mitch]

I used this in 306-112 so you are saying the above was for 307?

[Mike]

When working on fixes I use the most up to date version... otherwise I have to do things twice...
This is a bit of a departure from the norm but it saves me having to update two versions...

I may not have added all the fixes yet as I am still testing but 307 will get them first...

[Mitch]

I understand and agree.
I did a test install of phpbb307 and the latest SVN with the block_search fix and got this on automod install.

Code: Select all

styles/prosilver/template/quickreply_editor.html
Find

Comment: Required... See: manual_edits.txt file for slight adjustments after completion.

<form method="post" action="{U_QR_ACTION}">
   <div class="panel" style="display: none" id="qr_editor_div">
      <div class="inner"><span class="corners-top"><span></span></span>
         <div class="content">
            <h2>{L_QUICKREPLY}</h2>
            <fieldset class="fields1">
               <dl style="clear: left;">
                  <dt><label for="subject">{L_SUBJECT}:</label></dt>
                  <dd><input type="text" name="subject" id="subject" size="45" maxlength="64" tabindex="2" value="{SUBJECT}" class="inputbox autowidth" /></dd>
               </dl>
            <div id="message-box">
               <textarea style="height: 9em;" name="message" rows="7" cols="76" tabindex="3" class="inputbox"></textarea>
            </div>
            </fieldset>

Replace With

<form method="post" action="{U_QR_ACTION}" name="postform">
   <div class="panel" style="display: none" id="qr_editor_div">
      <div class="inner"><span class="corners-top"><span></span></span>
         <div class="content">
            <h2>{L_QUICKREPLY}</h2>
            <fieldset class="fields1">
               <!-- INCLUDE quickreply_buttons.html -->
               <dl style="clear: left;">
                  <dt><label for="subject">{L_SUBJECT}:</label></dt>
                  <dd><input type="text" name="subject" id="subject" size="45" maxlength="64" tabindex="2" value="{SUBJECT}" class="inputbox autowidth" /></dd>
               </dl>
               <!-- INCLUDE quickreply_smilies.html -->
            </div>
            <div id="message-box">
               <textarea style="height: 9em;" name="message" rows="7" cols="76" tabindex="3" class="inputbox"></textarea>
            </div>
            <!-- INCLUDE quickreply_options.html -->
            </fieldset>

The Find specified by the MOD could not be found

I think I read you changed something with it should I wait for a update to the SVN?